Quotient filter reviewed #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added initial QF builder functions
circular table, no extension slots
… into quotient-filter
simplify insertion
…its API so QuotientFilter can use it
fixed find_run_start() and removed adjustment in insert_new_run()
Common bitarray
no insertions of duplicates
ordered runs, simplified insertion code
style changes
expansion and some more cleanup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/org/apache/datasketches/filters/quotientfilter/QuotientFilter.java
Fixed
Show fixed
Hide fixed
| //hash_type = XxHash.hashLong ; //HashType.xxh; | ||
| } | ||
|
|
||
| public boolean rejuvenate(final long key) { |
Check notice
Code scanning / CodeQL
Useless parameter
| return success; | ||
| } | ||
|
|
||
| protected boolean _search(final long largeHash) { |
Check notice
Code scanning / CodeQL
Missing Override annotation
| Hence, the `large_hash` argument is already a hash key that has been generated | ||
| by the hashing library (eg xxhash). | ||
| */ | ||
| protected boolean _insert(final long largeHash) { |
Check notice
Code scanning / CodeQL
Missing Override annotation
constructor takes fingerprint length and load factor
This reverts commit ff12ef7.
implemented merge
Reverted double laod factor to float and corrected builder tests
| setFingerprint(index, fingerprint); | ||
| } | ||
|
|
||
| public String toString() { |
Check notice
Code scanning / CodeQL
Missing Override annotation
Member
Author
|
I'm going to close this for now. This code is getting out-of-date and we don't have the resources with the right skills to work on it now. When we do, we can reopen this and revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.